Skip to content

Add socket extensions for cygwin #139524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add socket extensions for cygwin #139524

wants to merge 10 commits into from
+124 −57

Conversation

Berrysoft
Copy link
Contributor

@Berrysoft Berrysoft commented Apr 8, 2025 •
edited
Loading

r? @joboet

  • Abstract name uds addr
  • quickack
  • passcred

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 8, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Berrysoft Berrysoft marked this pull request as ready for review April 8, 2025 15:03
@Berrysoft
Copy link
Contributor Author

Berrysoft commented Apr 9, 2025 •
edited
Loading

Some limitations:

  • Cannot connect the addr from recvfrom of a unix datagram socket.
    • It seems like a bug of cygwin.
    • A patch has been proposed.
    • UPDATE: patch merged. Now the test passes.
  • Cannot bind to abstract addr - not supported by cygwin.
  • Unbounded unix socket has an abstract local addr - a feature (autobind?) of cygwin.
  • Unix socket doesn't support recvmsg with control data. It fallbacks to recvmsg without control data.
  • Unix socket connect blocks until the server accepts it. See mailing list. I have to ignore some tests because of that.

@Berrysoft Berrysoft force-pushed the cygwin-socket-ext branch 2 times, most recently from e0b30bf to ce3ee0c Compare April 11, 2025 01:55
@jieyouxu jieyouxu added the O-cygwin Target: *-pc-cygwin label Apr 25, 2025
@bors
Copy link
Collaborator

bors commented Jun 29, 2025

☔ The latest upstream changes (presumably #143157) made this pull request unmergeable. Please resolve the merge conflicts.

@mati865
Copy link
Member

mati865 commented Aug 10, 2025

I think Jonas doesn't do reviews currently. @Berrysoft can you solve conflicts? We will reroll the reviewer.

@Berrysoft
Copy link
Contributor Author

Thanks! I have rebased the PR.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@mati865
Copy link
Member

mati865 commented Aug 11, 2025

Thanks.

r? rust-lang/libs

@rustbot rustbot assigned thomcc and unassigned joboet Aug 11, 2025
@mati865
Copy link
Member

mati865 commented Aug 23, 2025

Rerolling: #144651 (comment)

r? rust-lang/libs

@rustbot rustbot assigned tgross35 and unassigned thomcc Aug 23, 2025
tgross35
tgross35 requested changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a docs request then r=me with a squash

View changes since this review

library/std/src/os/unix/net/tests.rs
Comment on lines -459 to +470
#[cfg(any(target_os = "android", target_os = "linux"))]
#[cfg(any(target_os = "android", target_os = "linux", target_os = "cygwin"))]
#[test]
#[cfg_attr(target_os = "cygwin", ignore)] // Cygwin cannot bind to abstract addr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these tests eventually be run? It seems a bit unusual (though logical) to have them opt-in enabled, and then opt out of running.

library/std/src/os/cygwin/net.rs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The limitations mentioned in #139524 (comment) would be good to document in-tree. Could you add them to the doc comment of this file?

It would be good to mention whether each limitation comes from (1) cygwin bugs that we expect to be fixed, (2) features that aren't supported but could be, (3) some kind of bigger limitation that probably won't happen.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 requested changes

Assignees

@tgross35 tgross35

Labels
O-cygwin Target: *-pc-cygwin O-unix Operating system: Unix-like S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Berrysoft @rust-log-analyzer @bors @mati865 @tgross35 @thomcc @joboet @jieyouxu @rustbot